[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Rename text-base variables in update-editor.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 7 Apr 2010 15:30:41 -0400

Why do some names use text_base and others use pristine? Aren't those
the same thing?

On Wed, Apr 7, 2010 at 13:05, Julian Foad <julian.foad_at_wandisco.com> wrote:
> I'm going to apply this patch or something like it, tomorrow.  The new
> names are very helpful in matching up text-base checksums to the
> corresponding (old, current, new, copied, revert, ...) text base paths.
>
> Trawling through all this is also helping me to understand the text-base
> manipulations in the update editor, and my next move here will be to
> replace the old text-base paths with new WC-NG pristine store functions,
> which is now looking pretty straightforward in this part of the code.
> I'll just do any stream wrapping necessary to ensure the MD5 checksums
> are still calculated as well as the new SHA1s.
>
> Any comments about this renaming?  A mass rename could affect anybody's
> patches in progress but it should be simple enough to merge.  Let me
> know if there's a particular reason to hold off for a short time.
>
> - Julian
>
>
Received on 2010-04-07 21:31:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.