[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r929382 - /subversion/branches/1.6.x-wc-ng-error/subversion/libsvn_wc/questions.c

From: Peter Samuelson <peter_at_p12n.org>
Date: Wed, 31 Mar 2010 12:47:59 -0500

[Bert Huijben]
> > > > wc_db_path = svn_path_join_many(pool, abspath,
> > SVN_WC_ADM_DIR_NAME,
> > > > "wc.db", NULL);
> > >
> > > Shouldn't this use svn_wc_get_adm_dir()?
> >
> > Probably ... but since this is 1.6-specific code (it is not and never
> > will be in trunk), I think we'd need a good reason to bother changing
> > it.
>
> Is the common use of "_svn" by setting an environment variable, on
> Windows a good enough reason for you?

Yes, that would be a good reason. But as Julian noted on IRC, it's a
separate bugfix, so please patch and propose it separately.

Peter
Received on 2010-03-31 19:48:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.