[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] delta_files() speedup 2/3: keyword substitution

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 29 Mar 2010 17:20:12 +0100

Julian Foad <julian.foad_at_wandisco.com> writes:

>> * subversion/libsvn_subr/subst.c
>> (translation_baton): the 'interesting' member is now
>> a boolean array.
>> (create_translation_baton): adapt initialization code
>> (translate_chunk): eliminate call to strchr
>>
>> patch by stefanfuhrmann < at > alice-dsl.de
>> ]]]
>
> This patch looks lovely, from the point of view of a read-through
> review.

Agreed.

To get rid of the initialization we could use 4 static constant arrays
(we could even partially overlap them to save memory), but that's
probably not a significant improvement.

-- 
Philip
Received on 2010-03-29 18:20:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.