[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r919460 - filtering svn patch targets

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 27 Mar 2010 16:39:51 +0100

On 27.03.2010 15:23, Stefan Sperling wrote:
> On Fri, Mar 26, 2010 at 07:57:09PM +0100, Stefan Küng wrote:
>> On 26.03.2010 18:17, Stefan Sperling wrote:
>>> Can you check if the current API matches your requirements?
>>> See subversion/tests/libsvn_client/client-test.c for a trivial example.
>>
>> Looks very good! Thanks a lot for implementing this.
>
> Great! You're welcome.
>
>> Another thought, not sure if it would make sense or not:
>> would an option to ignore whitespace changes make sense?
>
> Yes, I guess we could easily make the line-matching ignore whitespace.
> Matching is currently done using a simple strcmp(), so it's fairly naive.
>
> Please file an enhancement issue, with undefined schedule (if someone
> wants to pick this up before 1.7.0, that's fine -- but it's not a
> critical feature).
>
> Ignoring whitespace would help dealing with diffs messed up by e.g. gmail.
> Though I've seen gmail use some magic UTF-8 sequences for whitespace,
> which is really annoying and which a naive approach like ignoring
> single-byte characters like ' ', '\t', etc. may not cope with.

Filed as issue 3610:
http://subversion.tigris.org/issues/show_bug.cgi?id=3610

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2010-03-27 16:40:25 CET

This is an archived mail posted to the Subversion Dev mailing list.