[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r924201 - in /subversion/trunk/subversion: libsvn_client/mergeinfo.c libsvn_subr/mergeinfo.c tests/libsvn_subr/mergeinfo-test.c

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 18 Mar 2010 17:34:15 -0400

On Wed, Mar 17, 2010 at 05:37, <julianfoad_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_subr/mergeinfo.c Wed Mar 17 09:37:11 2010
>...
> @@ -763,20 +765,31 @@ svn_rangelist_merge(apr_array_header_t *
>   return SVN_NO_ERROR;
>  }
>
> +/* Return TRUE iff the forward revision ranges FIRST and SECOND overlap and
> + * (if CONSIDER_INHERITANCE is TRUE) have the same inheritability. */
>  static svn_boolean_t
>  range_intersect(const svn_merge_range_t *first, const svn_merge_range_t *second,
>                 svn_boolean_t consider_inheritance)
>  {
> +  SVN_ERR_ASSERT_NO_RETURN(IS_VALID_FORWARD_RANGE(first));
> +  SVN_ERR_ASSERT_NO_RETURN(IS_VALID_FORWARD_RANGE(second));

If somebody manually tweaks an svn:mergeinfo property to include 0,
then is our library going to dump core?

(I imagine props are checked much earlier, but a new core dump is
always something to question :-P )

>...

Cheers,
-g
Received on 2010-03-18 22:34:47 CET

This is an archived mail posted to the Subversion Dev mailing list.