[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r919460 - filtering svn patch targets

From: Stefan Sperling <stsp_at_elego.de>
Date: Sat, 13 Mar 2010 09:41:06 +0100

On Fri, Mar 12, 2010 at 11:12:38PM -0800, Joe Swatosh wrote:
> On Fri, Mar 12, 2010 at 1:45 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> > On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
> >> Stefan Sperling wrote:
> >> >>> What is not possible (without adding the --include-pattern option)
>
> >
> > It does. You can manually revert the edits 'svn patch' made to the file.
> > Whether this is feasible or not really depends on the kind of modifications
> > the user and the patch are making. But it seems to me like the tortoise
> > GUI was designed around the assumption that users will often want to
> > apply only parts of patches at file-level granularity. I don't believe
> > that this is what people do in reality, so I'm questioning this GUI
> > design because it has repercussions on the svn patch API.
> > (I didn't really think about this before working on fixing #3434
> > unfortunately.)
> >
>
> Speaking up as a user of TortoiseSVN here, I use this several times a
> week at work.

OK, great then. So people need this.

That means that I'll eventually add an --include-patterns option to the
CLI client. I don't see the point of having a libsvn_client API that
tortoiseSVN uses to provide a useful feature, but have the CLI client
not expose this useful feature.

Julian, are you fine with that? Or would you like the option names
to be more specific to 'svn patch'? I've kept the option's name
general on purpose to encourage re-use of this option by other
subcommands (if they have a use for this option). Which I hope
will help keep the CLI interface as consistent as possible.

> Despite Stefan K's protestations, I encouraged him some
> time back to get involved in this because without dinking with line
> endings and other nonsense TortoiseSVN is by far the best way I've
> found to apply patches on Windows.

I also highly appreciate Stefan K's feedback. Even though in this thread
it may have seemed like I was primarily arguing against his points,
the point of doing so is not to "win" the argument, but to make sure
we're really considering things from different angles, and have people
present the reasoning behind their opinions, so we have a higher
chance of ending up with something everyone is happy with.

> While I have no skin in the development game, "svn patch" is a feature
> that I'm very excited about using in the future.

Cool, thanks!

Stefan
Received on 2010-03-13 09:42:08 CET

This is an archived mail posted to the Subversion Dev mailing list.