[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921810 - in /subversion/trunk/subversion/libsvn_subr: deprecated.c mergeinfo.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 11 Mar 2010 23:58:15 +0000

Greg Stein wrote:
> This is good, but I was also talking about the header: it doesn't have
> SVN_DEPRECATED for these functions. Thus, the use of
> svn_rangelist_inheritable in that old implementation of
> svn_mergeinfo_inheritable did not show up.

Yup, I realized after that commit (moving the function definition) that
that step should have come after (or at the same time as) marking the
thing as deprecated. But, looking at it, I'm not 100% willing to
declare it deprecated and the new one to be a total replacement. It
looks to me like the interface (and doc string) are getting a bit muddy
now it's got this sense-reversal parameter.

Having touched it, I suppose I'd better go on and do something about it.
It's still in my sights.

- Julian

> On Thu, Mar 11, 2010 at 06:51, <julianfoad_at_apache.org> wrote:
> > Author: julianfoad
> > Date: Thu Mar 11 11:51:52 2010
> > New Revision: 921810
> >
> > URL: http://svn.apache.org/viewvc?rev=921810&view=rev
> > Log:
> > Move two deprecated functions to 'deprecated.c'.
> >
> > * subversion/libsvn_subr/deprecated.c
> > (svn_mergeinfo_inheritable, svn_rangelist_inheritable): Move from ...
> >
> > * subversion/libsvn_subr/mergeinfo.c
> > (svn_mergeinfo_inheritable, svn_rangelist_inheritable): ... here.
Received on 2010-03-12 00:59:49 CET

This is an archived mail posted to the Subversion Dev mailing list.