[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [fsfs revprop packing] 'hotcopy' and a live sqlite revprops.db

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 27 Feb 2010 18:07:18 +0200 (Jerusalem Standard Time)

Filed this as <http://subversion.tigris.org/issues/show_bug.cgi?id=3596>.

Thanks,

Daniel

Stefan Sperling wrote on Sat, 27 Feb 2010 at 13:02 +0100:
> On Fri, Feb 26, 2010 at 02:34:54AM +0200, Daniel Shahaf wrote:
> > fs_fs.c:svn_fs_fs__hotcopy() uses this code to copy revprops.db:
> > 1597 /* Copy the packed revprop db. */
> > 1598 if (format >= SVN_FS_FS__MIN_PACKED_REVPROP_FORMAT)
> > 1599 {
> > 1600 SVN_ERR(svn_io_dir_file_copy(src_subdir, dst_subdir, PATH_REVPROPS_DB,
> > 1601 pool));
> > 1602 }
> >
> > This post <http://thread.gmane.org/gmane.comp.db.sqlite.general/48391/focus=48423>
> > on the sqlite-users mailing list implies that an exclusive lock must be
> > used for copying an sqlite db, and that plain copying might result in
> > a corrupt database.
> >
> > As far as I can see, 'hotcopy' doesn't take the steps recommended
> > in that (sub)thread to avoid corruption.
> >
> > Could someone more familiar with sqlite comment on this? Could
> > 'hotcopy', as now written, potentially corrupt the revprops db
> > (of the hotcopy target)?
>
> Can you file an issue, please?
>
> Thanks,
> Stefan
>
Received on 2010-02-27 17:07:31 CET

This is an archived mail posted to the Subversion Dev mailing list.