Re: [PATCH]: add section links (was: new website & IRC bot)

On Tue, 9 Feb 2010, Julian Foad wrote:

> On Tue, 2010-02-09, Martin Furter wrote:
>> I've created a copy and applied that patch-template:
>> http://svn-test.borg.ch/
>>
>> Mmm, nice :)
>>
>> Here's an attempt at a patch...
>
> Thanks! Please tell me you did that with a script, not by hand. You
> might want to enhance your script to catch sections like this one ...

Heh, ofcourse it's a script, I'm too lazy to do that manually :)

>> <div class="h4" id="pre-lock-hook-output" title="pre-lock-hook-output">
>> <h4>Changed handling of output of <code>pre-lock</code> hook</h4>
>
> ... which it missed. (I'm guessing it's because of mark-up within the
> heading.)

Yes, and that's one of the simpler cases. There are also some entries
where the opening and closing tag are not on the same line. I guess I need
to make the script a lot smarter...

Thanks for the review,
Martin
Received on 2010-02-10 00:49:00 CET