RE: two questions (and a proposed patch) regarding svn:ignore

> -----Original Message-----
> From: Julian Foad [mailto:julianfoad_at_btopenworld.com]
> Sent: woensdag 3 februari 2010 1:11
> To: 'Stefan Sperling'
> Cc: Bert Huijben; 'Subversion Development'
> Subject: Re: two questions (and a proposed patch) regarding svn:ignore
>
> On Tue, 2010-02-02, 'Stefan Sperling' wrote:
> > On Tue, Feb 02, 2010 at 09:12:42PM +0100, Bert Huijben wrote:
> > > In this libsvn_client_addX() case it would be adding an extra boolean to
> > > pass to the new svn_client_addX() function... And passing the right value
> > > from the wrapper in deprecated.c.
> >
> > Right, no problem. So we add svn_client_add5, with boolean
> > 'no_global_ignores' and 'no_svn_ignores' (better name anyone?).
>
> While we're revving it, consider this API design point. We pass the list
> of global ignores in to the function through the CTX parameter. It seems
> stupid to have an additional parameter that says whether to ignore the
> global ignores. Instead, the caller should set
> CTX->config['config:miscellany:global-ignores'] to empty before calling
> this function.
>
> Makes sense?

From 'svn' it makes sense to move the setting to the configuration as 'svn' use a new 'svn_client_ctx_t' for every command.

But, in several other clients the svn_client_ctx_t is a long living object. (This is becoming more useful in WC-NG as it will keep the handle to the wc.db instance open for you over multiple commands).

This would require setting the setting before executing the command and then resetting it later in the compatibility wrapper (and in other libraries that don't want to change their api incompatible).

        Bert
Received on 2010-02-03 11:54:12 CET