Re: svn commit: r902303 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_wc/lock.c

On Wed, Jan 27, 2010 at 10:35:55AM +0000, Philip Martin wrote:
> Stefan Sperling <stsp_at_elego.de> writes:
> > Can we apply your patch to fix the ordering problem?
>
> I think we should apply it, but the patch tests fail.

I will take a look.

> It raises the question: why are the patch tests taking a lock? They
> seem to pass without the lock. Does this mean the lock is
> unnecessary? Or does it mean that there is some code that requires a
> lock but is not checking to make sure that a lock is held?

The patch can modify the working copy in arbitrary ways.
It can delete files or directories, add new ones, etc.

The lock is held to say "I am starting a long-running operation
modifying the working copy and I don't know what the end result
will be yet! Everyone else please back off."

Stefan
Received on 2010-01-27 12:07:31 CET