RE: [PATCH] Make svn clients indicate their operation name to backend(right now only to DAV) Version 2

>Sorry, Kamesh, that wasn't a very helpful question.

>I know the aim is to to fix the problem that occurs during a commit
>through a proxy server - that's the one-line overview. I know the patch
>adds new parameters to a bunch of functions and sets them to particular
>values and such like - I can see that by reading the patch. What I meant
>was please can you show us the log message, tell us what protocol
>changes it makes, what specific cases it fixes and what it doesn't, say
>whether it addresses any of the points Mike raised and in what ways,
>that sort of thing.

The patch is in concept complete(Yet to run through the testsuite and to justify few cases by exercising those code base, which I will do tomorrow) to make the indication of 'commit' operation via the new header 'SVN-COMMIT'. With this patch original problem gets fixed.

All the function signature changes just accepts a new boolean parameter 'for_commit' which is set to TRUE only by commit.c:apply_revprops() while others set it to FALSE and hence no SVN-COMMIT header.

As it was a in concept patch I just did not write a log message, sorry for that.

With regards
Kamesh Jayachandran
Received on 2010-01-18 19:17:48 CET