Re: fixing old revisions referenced in log messages ...

On Tue, 2009-12-08 at 13:05 +0530, Senthil Kumaran S wrote:
> Senthil Kumaran S wrote:
> > You can get a sample run (20 MB) of the modified script here -
> > http://people.apache.org/~stylesen/sample_run_r836401_r880642.txt

Thank you. I diffed it against the original log messages, and I attach a
selection from that diff (just a few pages from the beginning, a few
from the middle and a few from the end) to this email.

This shows several interesting points. I think you should support the
following patterns which occur a significant number of times:

* Match the patterns as a whole "word" only, where a "word" consists of
at least letters, numbers and dash, so "bar100" and
"branches/1.6.x-r38000" are not converted.

* Recognize "r1234-5678" and "r1234:5678" revision-range syntaxes.

* Recognize:
  "revision RANGE"
  "Revision RANGE"
  "rev RANGE"
  "Rev RANGE"
  "rRANGE"
  "-rRANGE"
  "-r RANGE"
  "-cCHANGES"
  "-c CHANGES"
  "..._at_REV"

  where RANGE is "REV" or "REV:REV" or "REV-REV", and CHANGES is "RANGE"
or "RANGE,RANGE" or "RANGE,RANGE,RANGE" etc.

* Don't convert revision number 0, or any revision numbers less than say
10 or 100. By inspection, I recommend not converting any numbers less
than 60. Smaller numbers almost exclusively refer to special cases and
test cases rather than the main repository.

Some awkward messages to look at:

  r839673: "Revert back to rev1.6 of props.c."
  r843103: "Revisions 3027 and 3028"
  r843712: "grep -v -e '------' | cut -c 16- | grep '^[A-Z]'"
  r868530: Low numbers used as examples.
  r870655: long list of rev nums
  r871408: crazy "-c" with white space and commas
  r871433: "Vote for r30748, r31059, 31060, 31061"
  r871699: "Vote for r31620/31622"
  r875663: "Merged /trunk:r35494-35524,35526-35588"

> I ve filed a INFRA ticket to get a schedule to run this script on the
> repository - https://issues.apache.org/jira/browse/INFRA-2366

The ticket talks about disabling "pre-revprop-change" hook. Don't you
mean "post-revprop-change"?

- Julian