Re: [PATCH][RFC] allow local file:// URLs for svnadmin

On Fri, Dec 4, 2009 at 3:50 PM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> Vincent Legoll wrote:
>> I think there's nothing preventing svnadmin to accept local
>> file:// URLs as repository location parameter. So why not ?
>
> Let me ask a different question: Why? (We don't add features just
> because we can, we add them because they are useful enough to
> be worth the maintenance.)

I understand the maintenance burden, and that was the point I wanted
to raise with that question about usefulness.

> I can think of a reason: it could be handy to copying URLs between
> "svn" and "svnlook" and "svnadmin" commands.

That's what make me try to do the patch, I didn't cut'n'paste from
another svn* command but from a tailor (SCM migration tool) config
file, but that's the idea behind the patch yes...

> Is that your reason? Is there any stronger reason?

Yes, user-least-surprise or you-try-something-and-it-just-work,
when I saw the error message about URL not being accepted,
I told myself: "WTF, this is a damn local file:// URL"

> Would you add it to svnlook as well?

If the idea is acceptable and the work I'll put into is not lost, yes
I'll do it.

> If you want to do this, remember that converting a URL to a local path
> is not as simple as stripping off a prefix: there are at least two
> different prefixes (file://localhost as well), and you have to un-escape
> the URL escaping.

Yes, I think the final patch will be somewhat bigger, I didn't actually
look, but will, maybe URL handling code that could be borrowed is already
there...

Thanks for the quick answer

-- 
Vincent Legoll
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2427067
Please start new threads on the <dev_at_subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.