Re: [PATCH v3] Fix failing three way diff for properties

On Wed, 2009-11-11 at 19:34 +0100, Stefan Sperling wrote:
> On Wed, Nov 11, 2009 at 06:53:52PM +0100, Daniel Näslund wrote:
> > Formatting of long lines can be difficult. Is this ok?
> >
> > [[[
> > new_conflict->mime_type = conflict->mime_type
> > ? apr_pstrdup(result_pool, conflict->mime_type)
> > : NULL;
> > ]]]
>
> I'd mildly prefer:
>
> [[[
> new_conflict->mime_type = conflict->mime_type ? apr_pstrdup(
> result_pool,
> conflict->mime_type)
> : NULL;
> ]]]

I prefer an olive shade of green:

> new_conflict->mime_type
> = conflict->mime_type ? apr_pstrdup(conflict->mime_type) : NULL;

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416688
Received on 2009-11-11 19:41:03 CET