Re: [RFC] Paths API (svn_dirent_uri.h) - improvements

On Wed, Nov 11, 2009 at 12:25:49PM +0000, Julian Foad wrote:
> DIRENT:
>
> A "dirent" represents a native operating-system path... but let's be
> clear exactly what kinds of absolute and relative path this includes.
>
> The representation seems a bit odd, using Subversion's "canonical path"
> rules ("/" separator, etc.), rather than the native form, and so
> requiring "to_internal_style" and "to_native_style" conversions.

One observation I've made recently: On UNIX, passing a path containing
backslash-separators (e.g. a path parsed from a patch file) to
svn_dirent_internal_style() does absolutely nothing.
It just returns the path unmodified.

On Windows, passing a path containing backslash-separators
to svn_dirent_internal_style() does convert any backslashes
to forward slashes...

So the to_internal_style and to_native_style don't even work
as one might expect -- they don't always convert to the internal
style, it depends on the platform.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416546
Received on 2009-11-11 14:08:38 CET