[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove 'svnver' array warning in svndiff.c when

From: Gavin Baumanis <gavinb_at_thespidernet.com>
Date: Wed, 11 Nov 2009 10:07:36 +1100

Ping. This Submission has received new comments.

Gavin.

On 05/11/2009, at 04:09 , Philip Martin wrote:

> Edmund Wong <ed_at_kdtc.net> writes:
>
>> During a Windows compile under VS2008, the following warning is
>> shown:
>>
>> ..\..\..\subversion\libsvn_delta\svndiff.c(193): warning C4295:
>> 'svnver' :
>> array is too small to include a terminating null character
>
>> Index: subversion/libsvn_delta/svndiff.c
>> ===================================================================
>> --- subversion/libsvn_delta/svndiff.c (revision 40372)
>> +++ subversion/libsvn_delta/svndiff.c (working copy)
>> @@ -190,7 +190,7 @@
>> /* Make sure we write the header. */
>> if (eb->header_done == FALSE)
>> {
>> - char svnver[4] = "SVN\0";
>> + char svnver[4] = {'S','V','N',0};
>> len = 4;
>> svnver[3] = eb->version;
>> SVN_ERR(svn_stream_write(eb->output, svnver, &len));
>
> The old code is valid C as I think you know. It's a slightly obscure
> corner of the language; perhaps we should use {'S', 'V', 'N', '-'} to
> indicate that it is not a null terminated string.
>
> --
> Philip
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414466

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416307
Received on 2009-11-11 00:08:22 CET

This is an archived mail posted to the Subversion Dev mailing list.