On Fri, Nov 06, 2009 at 12:59:02PM +0530, Kannan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Stefan Sperling wrote:
> > Sorry, this got lost.
> >
> > I've just tested your patch. It changes output -- svn info shows
> > absolute paths instead of relative paths. This in itself is not
> > a huge problem, we know that it happens as part of the wc-ng transition,
> > and we may have to figure out a way to make absolute paths relative
> > for command line client output if possible.
> >
> > But the problem is that the changed output breaks tests.
> > I've only tested info_tests with your patch, and info tests 2 and 3
> > are failing. Please run all tests and make sure they pass before sending
> > patches. If you cannot get a test to pass, mention this in your patch
> > submission and ask for help. It's important to run *all* tests on a
> > patch, because breakage sometimes shows up in unexpected places. This
> > is quite time consuming but necessary.
>
> Thank you for the comments Stefan. I could see the info tests 2 and 3
> fail, as the path returned is an absolute one. Should we make a
> transition again to relative paths for the output?
It's not clear to me yet how we're going to translate absolute paths
to relative paths in all cases.
I think for now it's fine to adjust the tests to expect absolute paths.
See patch_unidiff_absolute_paths in patch_tests.py for an example of
how we can deal with absolute paths in tests.
Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415706
Received on 2009-11-09 09:33:40 CET