[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix some deprecation warnings

From: Kannan <kannanr_at_collab.net>
Date: Mon, 09 Nov 2009 11:15:01 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Rall wrote:
> On Fri, Nov 6, 2009 at 11:08 AM, Branko ─îibej <brane_at_xbc.nu> wrote:
>> Daniel Rall wrote:
>>> 2) Why use svn_uri_join() rather than svn_dirent_join()?
>> uri_join is for paths within the versionable filesystem, and URLs to
>> entities in a repository. dirent_join is for paths in the WC. As I
>> learned the hard way.
>
> Yep yep.
>
> The documentation that I cited, plus the fact that we're in
> libsvn_client here, makes me think that we're referencing local file
> system paths; doesn't that mean we want svn_dirent_join()? (And maybe
> that's what you're getting at.)

Thank you Branko/Daniel, for your comments. DIR entries are relative to
root of ra session, doesn't that mean we use svn_relpath_join()? And for
the other case(from your comments) use svn_dirent_join() as it points
only to local absolute paths, or I'm still not getting you?. But the
'ls' tests seem to pass for me for the patch I sent, which is odd?

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSvesXHlTqcY7ytmIAQLQHQf/dgz7E5hN//U52S7ZnT13frD43mCThXg+
1MVTUOsJmTKWSc4tDj7eiJRdP7faXxJFEJhp1fIsLQQMsZOBT/8LGBNLuL7lUp8r
rkc4Y2HQyfZ9j+Ohk6p5gH4qsTdeC0ZVugKN2ZPyVARh6wl42hYKeT9rD1Sq6jY+
0nNtnnci3WNsG7YEqsNN7d0uN+GErWO6ZlLyFgajB1CVAQhaqXdMgZ8ZiEnO3yi+
YXRmHbxs7+P1LXnuVF2wR+xk6K0y+iBWe15dzbK/BDb4PKlt5Hn90jZPE07ITgAA
Ld1Y8WLqESMC72z8q2CIyg/g4vP9fSirNppa3hWN2a6vws7UJ/7qVA==
=K9dl
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415680

Received on 2009-11-09 06:47:10 CET

This is an archived mail posted to the Subversion Dev mailing list.