Arfrever Frehtes Taifersar Arahesis wrote:
> 2009-11-07 20:27:54 Bert Huijben napisał(a):
>
>> What do you try to fix?
>>
>
> Public headers shouldn't include private headers.
>
>
I find myself agreeing in principle with Arfrever; however, the "fix" is
totally bogus because it breaks debug builds for anyone who's not using
GCC as their compiler. At the very least, you should test if your
preprocessor even supports the -include option, not just blindly assume
that any system that uses configure also uses GCC.
Next: What on earth is wrong with unconditionally including
private/svn_debug.h from an implementation file? You had to remove those
includes only because you added that #error directove in svn_debug;
which is totally unnecessary. It should be perfectly safe and acceptable
for a Subversion C file to include svn_debug.h in a non-debug build.
Next: Same goes for your handling of SQLITE3_DEBUG.
Verdict: -1, please revert this change. The principle you quote above
can be served simply by requiring implementation files that happen to
think they need SVN_DBG to include private/svn_debug.h explicitly. In
any case, your change breaks things for any number of people who don't
compile with GCC.
-- Brane
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415522
Received on 2009-11-08 07:31:16 CET