[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: Re: Issue #2580 revisited: Windows unclean TCP close [SEVERE]

From: Stefan Sperling <stsp_at_elego.de>
Date: Sat, 24 Oct 2009 21:40:49 +0200

On Sat, Oct 24, 2009 at 10:52:55AM -0700, Bob Denny wrote:
> > I'd rather be careful when changing the default to something that
> > is known to have caused problems in the past.
>
> Understood! But was it known to cause problems on Windows?

I don't know.

But it turns out that his has been mentioned before:
"The zombie problem is specific to unix-like systems and
does not affect windows."
http://subversion.tigris.org/issues/show_bug.cgi?id=2580#desc21

See also this version of Kyle McKay's issue #2850 patch:
http://subversion.tigris.org/nonav/issues/showattachment.cgi/993/client.c-patch_v2
It explicitly prevents the signal being sent on win32.

> What we want is for the client svn and server svnserve to be able to
> complete their work with an EOF exchange at the SVN protocol level.
> This will allow (cause) the remote svnserve to exit normally. Then
> have the client close the fd, (an EOF to the SSH tunnel) which will
> allow (cause) the client and server SSH tunnel pair to gracefully
> complete the SSH closing exchange, at which time both the local tunnel
> agent and the remote sshd will exit normally. Finally, the client
> exits normally. This is how it is designed to work. I spent a day
> reading code and protocol docs to learn about it.

I'll ask Bert, Paul and Daniel to take a look at this thread.
If they don't have any concerns I'd say let's just commit your patch
and hope that this stupid issue will finally die...

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411087
Received on 2009-10-24 21:41:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.