[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn_client_status and path relativity

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Sun, 11 Oct 2009 23:49:13 +0200

> -----Original Message-----
> From: news [mailto:news_at_ger.gmane.org] On Behalf Of Roman Donchenko
> Sent: zondag 11 oktober 2009 22:19
> To: dev_at_subversion.tigris.org
> Subject: svn_client_status and path relativity
>
> Hello,
>
> While debugging the last Python testsuite failure, I've come upon an
> issue
> in the info implementation.
>
> First of all, as I've already mentioned in IRC, the receiver argument
> to
> svn_client_info3 is of type svn_info_receiver2_t in the function
> declaration, but svn_info_receiver_t in the definition. As both types
> are
> identical, it doesn't cause any problems, but I'm listing it here for
> the
> record.
>
> Later on, however, in the aforementioned function we have:
>
> SVN_ERR(receiver(receiver_baton, base_name, info, pool));
>
> Why are we passing it the base name here? The parameter is called
> abspath_or_url, presumably it expects to be passed an absolute path or
> a
> URL. 8=]
>
> Moreover, I'm not sure what should be passed there. If we pass the URL
> in
> the repository, then info_receiver_relpath_wrapper will be unable to
> transform it into a relative path for svn_client_info2 users. And if we
> use the absolute path in the WC, we still won't achieve full
> compatibility: previously, "svn info mywc/blah.txt -rHEAD" would return
> "blah.txt" as the path, now it would return "mywc/blah.txt". And I'm

Second reply..

svn info mywc/blah.txt -rHEAD uses the url of mywc/blah.txt at revision HEAD
and never the working copy path, in any format. That hasn't changed.

The result only changed for the case where no -r or peg revision is
specified.. which specifies the working copy version.

The new version will return the absolute path, and the old version the
relative path. (And the old result is still provided for the old function
name via the wrapper in deprecated.c)

        Bert

> not
> sure which one is a better answer. The latter appeals to me more, but
> it's
> backwards incompatible.
>
> Roman.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageI
> d=2406436

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2406447
Received on 2009-10-11 23:49:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.