On Sat, Oct 10, 2009 at 14:23, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>...
> Something like this? I tested it and it doesn't behave as I expected it
> to; but I'm too confused to decide whether it's because the patch is bad
> or because I'm not rebuilding correctly.
>
> I should get some rest now...
>
> Daniel
>
> [[[
> Index: subversion/include/private/svn_debug.h
> ===================================================================
> --- subversion/include/private/svn_debug.h (revision 39926)
> +++ subversion/include/private/svn_debug.h (working copy)
> @@ -83,5 +83,8 @@ svn_dbg__printf(const char *fmt, ...);
> }
> #endif /* __cplusplus */
>
> +#else /* SVN_DEBUG */
> +#define SVN_DBG(ARGS) /* nothing */
> #endif /* SVN_DEBUG */
> +
> #endif /* SVN_DEBUG_H */
I don't think the header should change at all. SVN_DBG() should never
be left in (released) code. It is only for developers to use locally.
> Index: subversion/libsvn_subr/debug.c
> ===================================================================
> --- subversion/libsvn_subr/debug.c (revision 39926)
> +++ subversion/libsvn_subr/debug.c (working copy)
> @@ -21,9 +21,6 @@
> * ====================================================================
> */
>
> -/* These functions are only available to SVN developers. */
> -#ifdef SVN_DEBUG
> -
This change should be fine. The functions will be around, but unused.
Or, as Bert noted, some "third party" code might compile with
SVN_DEBUG and still have these functions available.
>...
> +++ subversion/svnversion/main.c (working copy)
> @@ -26,6 +26,8 @@
> #include "svn_utf.h"
> #include "svn_opt.h"
>
> +#include "private/svn_debug.h"
This is never needed. It's done automatically at the end of svn_types.h
>...
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2406216
Received on 2009-10-10 21:58:29 CEST