Re: Obliterate - call graph, esp. repos and FS layers

Julian Foad wrote:
> These last few days I've been working down through the layers, looking
> at a call graph something like this:
>
[...]
> svn_fs_begin_obliteration_txn()
>
[...]

> All of these APIs take a revision number as a parameter, and replace the
> specified revision with a modified version of itself.
>
> Thoughts?
>

Given that obliterate does everything differently from a normal
transaction, do you really need an obliteration txn on the API level?
you could really have a single svn_fs_obliterate(_path_rev) that handles
the underlying txn management. Unless you're thinking ahead to issuing
several obliterate commands in a single transaction; but in that case
your whole call chain would have to be different, at least up to the RA
layer.

Another question pops up: how do you obliterate a whole revision? the
use case being, e.g., to undo the last commit. Would that be "svnadmin
obliterate / HEAD"? How do we handle obliteration of directories in
general -- I only recall files being mentioned.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2403870
Received on 2009-10-05 21:51:07 CEST