[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use context_t in svn_wc_entries_read

From: Gavin Baumanis <gavinb_at_thespidernet.com>
Date: Sat, 12 Sep 2009 10:51:27 +1000

Hi Everyone,

Due to my recent absence I am find it a little difficult to track some
of the patch submissions of the last month.
Especially when the subject line changes!

Anyway,
There are a couple of context_t.... releated threads that all seem to
have an ending of, please resubmit with these fixes.
But I don't see a response (in all of them) saying that the fix was
completed or that the patch was committed.

Daniel,
Could I please just ask you to check you patch submissions and let me
know, if any, have been committed. - So I can remove those threads
from "Pending" folder.

Thanks
Gavin.

On 15/08/2009, at 03:32 , Daniel Näslund wrote:

> Hi!
>
> make check failed for:
> depth_tests.py 32
> switch_tests.py 18
> switch_tests.py 21
>
> Since those were failing on trunk, I'd say we're safe.
>
> I was looking at svn_wc_walk_entries3. It internally uses
> svn_wc_entries_read so I decided to change that first.
>
> The doc string for svn_wc_entries_read2 talks about parsing the
> entries
> file for adm_access. I'm not sure what it should say. Since the
> entries
> file is going to be replaced (is that already done?) with a db it
> probably should say something else.
>
> I was asking gstein about the caching of entries and he said that it
> was
> handled low level and that I didn't have to deal with it.
>
> [[[
> Use svn_wc_context_t in svn_wc_entries_read2.
>
> * subversion/include/svn_wc.h
> (svn_wc_entries_read2): New.
> (svn_wc_entries_read): Deprecate.
>
> * subversion/libsvn_wc/entries.c
> (svn_wc_entries_read2): New. Use absolute paths. Add svn_wc_context_t
> parameter.
>
> * subversion/libsvn_wc/deprecated.c
> (prune_deleted): Copy from entries.c.
> (svn_wc_entries_read): Reimplement as a wrapper.
> ]]]
>
> Mvh
> Daniel
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?
> dsForumId=462&dsMessageId=2383683<svn_wc_entries_read.diff>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2393771
Received on 2009-09-12 02:51:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.