[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*.

From: Edmund Wong <ed_at_kdtc.net>
Date: Tue, 01 Sep 2009 09:58:56 +0800

Stefan Sperling wrote:
> On Sat, Aug 29, 2009 at 12:39:07PM +0800, Edmund Wong wrote:
>> Since the svn_eol_* functions are in the private
>> headers, Arfrever pointed out that they should be
>> renamed to s/svn_eol_/&_/g.
>
> Some small remarks on the log message:

Even after all these submitted patches, I still can't seem
to get the log right. Quite a disappointment I must say. Sorry about
that.

> You might want to put a short note describing the overall change
> here, unless the change is really trivial. In this case, we could
> say:
>
> "Follow-up to r38983: The new eol functions are supposed to be private,
> not public, so rename them accordingly."
>> * subversion/libsvn_subr/eol.c,
>> subversion/libsvn_diff/diff_file.c,
>
> The asterisk alone is a good enough visual hint for the grouping.
> So the indentation isn't needed, and these can all go on the same
> line, like this:
>
> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_diff/diff_file.c,

I'll keep these in mind.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2389610
Received on 2009-09-01 04:26:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.