[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*.

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 31 Aug 2009 06:13:23 -0500

On Aug 31, 2009, at 6:06 AM, Stefan Sperling wrote:

> On Mon, Aug 31, 2009 at 05:55:55AM -0500, Hyrum K. Wright wrote:
>>
>> On Aug 31, 2009, at 5:18 AM, Stefan Sperling wrote:
>>
>>> On Sat, Aug 29, 2009 at 12:39:07PM +0800, Edmund Wong wrote:
>>>> * subversion/libsvn_subr/eol.c,
>>>> subversion/libsvn_diff/diff_file.c,
>>>
>>> The asterisk alone is a good enough visual hint for the grouping.
>>> So the indentation isn't needed, and these can all go on the same
>>> line, like this:
>>>
>>> * subversion/libsvn_subr/eol.c,
>>> subversion/libsvn_diff/diff_file.c,
>>
>> Not to be pedantic (well, actually, I am being pedantic), but the
>> examples in HACKING include the indentation for each file in a
>> condensed file list. See
>> http://subversion.tigris.org/hacking.html#log-messages
>
> The indentation you are quoting me for there does not match what I
> sent.
> Maybe tigris is mangling my mail again?
>
> Let's try again.
>
> Good:
> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_diff/diff_file.c,
>
> Bad:
> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_diff/diff_file.c,

And the "Bad" version is what is shown in HACKING as Good. :)

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388846
Received on 2009-08-31 13:13:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.