[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38890 - trunk/subversion/libsvn_wc

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 24 Aug 2009 19:55:14 +0200

On Aug 23, 2009, at 7:32 PM, Greg Stein wrote:

> On Thu, Aug 20, 2009 at 15:30, Hyrum K.
> Wright<hyrum_at_hyrumwright.org> wrote:
>> ...
>> +++ trunk/subversion/libsvn_wc/entries.c Thu Aug 20 12:30:08
>> 2009 (r38890)
>> ...
>> @@ -3264,7 +3263,7 @@ svn_wc__walker_default_error_handler(con
>> {
>> /* Note: don't trace this. We don't want to insert a false "stack
>> frame"
>> onto an error generated elsewhere. */
>> - return err;
>> + return svn_error_return(err);
>> }
>
> Really?! Come on, man. Read the comment **right above that return**

Maybe the comment is bogus. I actually found the included stack frame
to be valuable in attempting to debug a problem. But in the end, I
suppose I just like my bike sheds chartreuse.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386803
Received on 2009-08-24 19:55:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.