[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]remove adm_access batons in svn_wc_translated_file3()

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 10 Aug 2009 14:39:14 +0100

Here are just a couple of comments; this is not a review.

On Mon, 2009-08-10, HuiHuang wrote:
> Index: subversion/include/svn_wc.h
> ===================================================================
[...]
> * Output files are created in the temp file area belonging to
> - * @a versioned_file. By default they will be deleted at pool cleanup.
> + * @a versioned_abspath. By default they will be deleted at scratch_pool cleanup.
> *
> * If @c SVN_WC_TRANSLATE_NO_OUTPUT_CLEANUP is specified, the default
> - * pool cleanup handler to remove @a *xlated_path is not registered.
> + * result_pool cleanup handler to remove @a *xlated_path is not registered.

The first of these two paragraphs refers to "scratch_pool cleanup" and
the second to "result_pool cleanup". Shouldn't they both refer to the
same pool?

[...]
> Index: subversion/libsvn_wc/translate.h
> ===================================================================
[...]
>
> +/* Internal version of svn_wc_translated_file3(). */

Saying "Internal version of ..." does not communicate any useful
information. Instead, say how this function differs from
svn_wc_translated_file3(). For example:

/* Like svn_wc_translated_file3(), except the working copy database
 * is specified directly by DB instead of indirectly through a
 * svn_wc_context_t parameter. */

> +svn_error_t *
> +svn_wc__internal_translated_file(const char **xlated_path,
> + const char *src,
> + svn_wc__db_t *db,
> + const char *versioned_abspath,
> + apr_uint32_t flags,
> + apr_pool_t *result_pool,
> + apr_pool_t *scratch_pool);

Thanks.
- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2382076
Received on 2009-08-10 15:39:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.