Re: svn commit: r38567 - in branches/1.6.x: . subversion/mod_dav_svn

On Wed, Aug 5, 2009 at 19:21, Stefan Sperling<stsp_at_elego.de> wrote:
> On Wed, Aug 05, 2009 at 01:12:59PM -0400, C. Michael Pilato wrote:
>> Now, some perspective.  Is this the most critical codepath in the system?
>> Does it merit scrutiny of this degree?  Perhaps not.  It's just that my
>> "change-without-good-reason" alarm went off, and I wanted to get to the
>> bottom of that.
>
> The bottom of that is Greg's brain.
> We'll have to get hold of it and ask it what it was thinking...

In repos.c, line 3011 (right after that code), there is the following comment:

          /* Probably serr->apr == SVN_ERR_BAD_MIME_TYPE, but
             there's no point even checking. No matter what the
             error is, we can't derive the mime type from the
             svn:mime-type property. So we resort to the infamous
             "mime type of last resort." */

And it proceeds to set "application/octet-stream".

Since we don't know whether the content is text or not, then assuming
it is and setting "text/$anything" would be a mistake. The
"application/octet-stream" is the most proper degenerate type.

Was this a change in behavior? Sounds like it did. That certainly
wasn't my intent.

Should it be put back to text/plain? I'd say "no", but that's what
discussion on the list is for :-)

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2381330
Received on 2009-08-07 16:57:08 CEST