[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue 3342 - summary of conflicts and skips

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 30 Jul 2009 19:15:04 +0100

Stefan Sperling wrote:
> OK. Note that Edmund Wong has been working on this issue, too,
> and I told him to do the stat gathering in libsvn_client.
> Maybe that is why he hasn't made much progress, given that it
> makes the task more difficult -- I gave him bad advice :(

Oh... I didn't remember that.

The information coming up from libsvn_client is "here are notifications
of all the things happening". I think it would be wrong to make
libsvn_client say "and also here is some summary information about those
notifications, classified in a particular way".

If we want to make the summary stats available from libsvn_client, one
way we could do it would be to make libsvn_client provide a notification
wrapper function that just does stat-counting and then forwards all
notifications on to the "real" notification function:

svn_error_t *
svn_client_get_stats_reporting_notifier(
  svn_wc_notify_func_t *wrapper_notify_func,
  void **wrapper_notify_baton,
  svn_wc_notify_func_t real_notify_func,
  void *real_notify_baton,
  ...);

and provide some way to read the stats out of it on request.

That way would not interfere with the current libsvn_client API and
would be replaceable if the particular client wanted stats classified
differently.

But I just don't think we need to make this available at libsvn_client
level unless we see other clients that would actually use it.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377088
Received on 2009-07-30 20:15:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.