[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Mismatched backwards compat callbacks in libsvn_wc

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 13 Jul 2009 13:05:42 +0100

On Sun, Jul 12, 2009 at 03:51:59PM +0400, Роман Донченко wrote:
> Stefan Sperling <stsp_at_elego.de> писал в своём письме Sat, 11 Jul 2009
> 00:36:15 +0400:
>
>> On Fri, Jul 03, 2009 at 01:06:23AM +0400, Роман Донченко wrote:
>>> /* An svn_wc_diff_callbacks3_t function for wrapping
>>> svn_wc_diff_callbacks_t. */
>>> static svn_error_t *
>>> -file_changed(svn_wc_adm_access_t *adm_access,
>>> +wrap_3to1_file_changed(svn_wc_adm_access_t *adm_access,
>>> svn_wc_notify_state_t *contentstate,
>>> svn_wc_notify_state_t *propstate,
>>> svn_boolean_t *tree_conflicted,
>>
>> Please indent the other parameters, too, so that they all align again
>> as they used to.
>
>> Same here.
>
>> Same here.
>
>> Same here.
>
>> Somehow it feels like I've seen this before...
>
> Yeah, I think I get your point. 8=] Fixed and reattached.

AFAIK you've already been given partial commit access.
As a partial committer you can commit any diff outside of your area
as long as a full committer gives you a +1.

So you can commit this yourself, and include this line in the log message:
Approved by: stsp

See also http://subversion.tigris.org/hacking.html#commit-access

Stefan
Received on 2009-07-13 14:06:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.