[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch Manager additional task?

From: Gavin Baumanis <gavinb_at_eclinic.com.au>
Date: Mon, 13 Jul 2009 03:21:27 +1000

Hi Daniel,

As always thanks for the reply and thoughts.

On 13/07/2009, at 2:45 AM, Daniel Shahaf wrote:

> Gavin Baumanis wrote on Mon, 13 Jul 2009 at 01:32 +1000:
>> A non-committer submits a patch to the project.
>> The patch is reviewed by another non-committer.
>> There may or may not be some corrections / amendments - but
>> ultimately, the patch is reviewed favorably.
>>
>> The issue is this use-case, is that the patch submission now
>> languishes in a "void" of sorts.
>> It's been reviewed, but does not get committed.
>>
>> ...
>>
>> Ultimately, my question is;
>> For the specific use-case above is it appropriate for the PM to
>> commit
>> the "languishing" patch submission?
>>
>
> And if a bug is found in code that entered the repository this way,
> who is
> responsible for it?
>

The OP, The reviewer, and the PM I suppose.
The process perhaps?

>> So testing code will certainly be "easy enough" and I'd certainly
>> like
>> to think that my svn "technical" skills will get better the more I am
>> involved, but is it enough?
>>
>
> Testing does not substitute review: if you tested a patch but don't
> feel
> your skills allow you to +1 it, then (IMO) you shouldn't commit it.
>
I'm not proposing at all that a patch that has not been reviewed
should be committed.

If "Bob" writes a patch to fix an issue he is having.
and "John" says I used your patch and it fixed my problem, but I
changed x and z.
Bob agrees that X and z was a good change and that indeed it works
properly now

And,

the patch is properly formatted, has an appropriate log message etc
etc...
and for whatever sits around and gathers dust and doesn't get committed.

I ping the list asking for review etc.
But it still doesn't get any interest from a full committer.

Normally I would send it to the issue tracker.
At this point - and not before, do I propose that the PM could
instead, commit the change.

I don't have any burning desire, as such, for doing the committing, it
was more brought about by is the project doing it all it can to
support patch submissions... and for the few that don't get
committed... are we treating them as best we can? As the PM, what MORE
can I do (if anything) if "ping" requests receive no response -
without sending it off to the issue tracker where it is now - out of
sight / out of mind.

It's frustrating to me, in the sense that it happens so very rarely -
really... that it should be a non-issue and thus I shouldn't really
need to worry about it all - but none the less it does happen and can
be frustrating for the OP and subsequently me too a little since I am
not in a position to really do anything about it to assist the OP.

It is sincerely about supporting the patch proposal and submitter as
best as we can that has me raising this email in the first place, I'm
certainly not going to take it personally - I simply don't have the
skills yet.

I am more than happy take advice in any direction that might help the
above scenario.

Gavin.

> Daniel
>
>> Really, It's a case of whether or not you feel it is a task you want
>> the PM doing?
>
>> Anyway - I put it out there for discussion.
>>
>> Gavin.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370767

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370772
Received on 2009-07-12 19:21:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.