[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38381 - in trunk/subversion: include libsvn_subr

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Fri, 10 Jul 2009 15:47:42 +0530

Julian Foad wrote:
> Author: julianfoad
> Date: Thu Jul 9 05:26:08 2009
> New Revision: 38381
...
> +/** Return the key of the hash table entry indexed by @a hi. */
> +const void *svn_apr_hash_index_key(const apr_hash_index_t *hi);

Should "hi" be 'const' here? Since "hi" does not get modified by calling
'apr_hash_this'.

> +/** Return the key length of the hash table entry indexed by @a hi. */
> +apr_ssize_t svn_apr_hash_index_klen(const apr_hash_index_t *hi);

Same here.

> +/** Return the value of the hash table entry indexed by @a hi. */
> +void *svn_apr_hash_index_val(const apr_hash_index_t *hi);

Same here.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2369633
Received on 2009-07-10 12:18:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.