[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38306 - in trunk/subversion: include libsvn_wc

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 6 Jul 2009 10:48:56 -0500

On Jul 5, 2009, at 12:39 PM, Greg Stein wrote:

> On Thu, Jul 2, 2009 at 17:33, Hyrum K. Wright<hyrum_at_hyrumwright.org>
> wrote:
>> ...
>> +++ trunk/subversion/libsvn_wc/props.c Thu Jul 2 08:33:34
>> 2009 (r38306)
>> ...
>> @@ -2076,40 +2074,48 @@ svn_wc_prop_set3(const char *name,
>> if (value && svn_prop_is_svn_prop(name))
>> {
>> const svn_string_t *new_value;
>> - struct getter_baton *gb = apr_pcalloc(pool, sizeof(*gb));
>> + struct getter_baton *gb = apr_pcalloc(scratch_pool,
>> sizeof(*gb));
>>
>> - SVN_ERR(svn_dirent_get_absolute(&gb->local_abspath, path,
>> pool));
>> - gb->db = svn_wc__adm_get_db(adm_access);
>> + gb->local_abspath = local_abspath;
>> + gb->db = wc_ctx->db;
>
> I know you're just tweaking, but this baton can/should just go onto
> the stack rather than the heap.

Good point. r38347.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368420
Received on 2009-07-06 17:49:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.