[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH]commit_from_multi_wc

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 01 Jul 2009 10:09:53 +0100

Bert Huijben wrote:
> > -----Original Message-----
> > From: HuiHuang [mailto:yellow.flying_at_yahoo.com.cn]
[...]
> > * subversion/include/svn_client.h
> > (svn_client_commit5): New API.
> > Which can do commit from multiple working copies. It does one
> > single
> > commit for each working copy.

[...]
> And can you add a argument that determines whether performing multiple
> commits over the same targets is allowed or not? This would allow
> implementing svn_client_commit4() as a wrapper over
> svn_client_commit5()

Let's not be too keen to add behaviour-changing flags in the public
APIs, as they make the APIs unwieldy and hard to read at the point of
use. For the purpose of implementing svn_client_commit4() as a wrapper,
a private implementation can take such a flag, but it need not be
exposed.

> and would also allow disabling the new functionality for library
> users that would like to explicitly manage this behavior.

What is the compelling reason to want this? (This is just a drive-by
observation and question. I am not following this issue closely and
there might very well be a good reason; I'd just like to see it spelled
out.)

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366973
Received on 2009-07-01 11:10:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.