[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38199 - in trunk/subversion: libsvn_client libsvn_wc

From: Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA_at_GMail.Com>
Date: Mon, 29 Jun 2009 15:42:44 +0200

2009-06-25 16:47 Hyrum K. Wright <hyrum_at_hyrumwright.org> napisał(a):
> Author: hwright
> Date: Thu Jun 25 07:47:23 2009
> New Revision: 38199
>
> Log:
> Remove some "format not a string literal, argument types not checked" warnings,
> and simplify a few format strings while we're at it.
>
> * subversion/libsvn_wc/update_editor.c
>  (window_handler, apply_textdelta, close_file),
> * subversion/libsvn_wc/questions.c
>  (compare_and_verify),
> * subversion/libsvn_wc/adm_crawler.c
>  (svn_wc_transmit_text_deltas2),
> * subversion/libsvn_client/export.c
>  (close_file):
>    Don't dynamically build error format strings, when they can just as
>    easily be indicated statically.

Could you revert this change? Separation of " expected: %s" and "
  actual: %s" messages allows to avoid the risk of inconsistent
translation of these messages and also reduces the amount of text
which need to be translated.

--
Arfrever Frehtes Taifersar Arahesis
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366356
Received on 2009-06-29 15:43:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.