Hi.
It seems that Troy Simpson have returned and done almost the same changes to the installer.
Therefore I think this case can be closed and forgotten.
/David
> Normally we can file the issue first and add the log message later...
>
> But for a 100KB patch? I think the first issue is the reduce it to
> managable size. Looking into it, one of the hunks has two 37K-character
> lines. That consist mainly of changing some absolute local paths (which
> shouldn't be versioned anyway). Perhaps we need to refactor that file (to
> wrap it and remove the absolute local paths) first.
>
> Gavin Baumanis wrote on Sat, 30 May 2009 at 12:38 +1000:
> > Hi David,
> >
> > Just following up on this patch submission of yours.
> > I was abut to log it into the issue tracker when I realised there
> > wasn't "really" a log message for the patch.
> > I was going to use your single line of text from your original mail,
> > but thought I would check if you felt that was sufficient?
> >
> > Please refer to;
> > http://subversion.tigris.org/hacking.html#patches
> >
> > for the patch submission guidelines - and of course feel free to ask
> > for any help you might need.
> >
> >
> > Gavin.
> >
> >
> > On 25/04/2009, at 6:36 AM, David Darj wrote:
> >
> > > Patch for the packages/windows-WiX installer to handle the fact that
> > > there are no binaries built for Apache 2.0 bindings<Svn-
> > > WindowsWiX-1.6.diff>
> >
> > ------------------------------------------------------
> > http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357047
> >
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2365416
Received on 2009-06-25 20:04:31 CEST