[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.6.3 up for signing/testing

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 20 Jun 2009 23:46:31 +0300 (Jerusalem Daylight Time)

Jens Peters wrote on Sat, 20 Jun 2009 at 11:10 +0200:
> On 20-6-2009 9:20, Daniel Shahaf wrote:
> > (On the other hand, it is currently *expected* that svnadmin_tests 12 or
> > 17 should FAIL when packing is enabled *at compile-time* --- unless
> > someone fixed it when I wasn't looking. I should document all these
> > details somewhere...)
>
> Yes, I see some failures now, so runtime packing seems somewhat strange
> now at this moment.
>

Well, hopefully no one runs with runtime packing in production --- it's
intended for debugging. But on the other hand, "runtime packing" is
a legitimate user of our svn_fs.h API (see svn_fs_commit_txn), so if we
have a bug here, then we *do* have a bug.

> Regards,
> Jens
>
> Details:
>
> FAIL: fs-pack-test.exe 1: pack a FSFS filesystem
> FAIL: fs-pack-test.exe 2: pack FSFS where revs % shard = 0
> FAIL: fs-pack-test.exe 3: read from a packed FSFS filesystem
> FAIL: fs-pack-test.exe 4: commit to a packed FSFS filesystem
> FAIL: fs-test.exe 21: check old revisions
> FAIL: fs-test.exe 22: after each commit, check all revisions
> FAIL: fs-test.exe 23: create and modify medium file (seed=2313125732)
> FAIL: fs-test.exe 24: create and modify large file (seed=2326574225)
> FAIL: fs-test.exe 25: ensure accurate storage of root node
> FAIL: fs-test.exe 27: test svn_fs_check_related
> FAIL: fs-test.exe 35: create and modify small file (seed=2368122020)
> FAIL: repos-test.exe 1: test svn_repos_dir_delta2
> FAIL: repos-test.exe 3: test svn_repos_history() (partially)
> FAIL: repos-test.exe 13: test svn_repos_get_logs ranges and limits
>
> The reason to fail for the binary tests is (or similar):
> Can't remove 'test-repo-fsfs-pack-even\revs\0': The directory is not empty.

IIRC, these are Windows-specific and don't happen on Linux. Dug into them
a while ago --- into FSFS and APR, etc. --- but never figured them out.

> FAIL: svnadmin_tests.py 12: svnadmin verify detects corruption dump can't
> FAIL: svnadmin_tests.py 17: fsfs recovery checks missing revs / revprops files
>
> The svnadim tests fail with:
> IOError: [Errno 2] No such file or directory:
> 'svn-test-work\\repositories\\svnadmin_tests-12\\db\\revs\\0\\2'
>

These move the rev files around manually to simulate corruption. I made
them DTRT (PASS or SKIP) when fsfs_sharding is set, but they don't yet
know about -DSVN_FS_FS_DEFAULT_MAX_FILES_PER_DIR.

> FAIL: svnadmin_tests.py 16: reflect dropped renumbered revs in svn:mergeinfo
>
> svnadmin: Can't check path
> 'svn-test-work\repositories\svnadmin_tests-16\db\revs\3\7': Access is denied
>
> WindowsError: [Error 3] The system cannot find the path specified
>

Oh-oh. That's a new one. I don't remember seeing it --- i.e.,
I assumed it would PASS. But perhaps it's also Windows-specific?
(I don't have a trunk build to test with at the moment, sorry)

> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2363759
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2363811
Received on 2009-06-20 22:46:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.