Hey Stefan,
Yes, I agree with you. Actually the test is passed in current state.
But it is not passed as we expect and I do not know how to distinguish
this unexpected pass from the expected pass in the future, so I raise a
failure exception and let it fails now.
Maybe I should remove the failure exception and XFail(), and it is
passed now?
Thanks~
HuiHuang
2009-06-12
yellow.flying
发件人： Stefan Sperling
发送时间： 2009-06-11 21:47:50
收件人： HuiHuang
抄送： dev
主题： Re: [PATCH] commit_tests
On Thu, Jun 11, 2009 at 07:40:08PM +0800, HuiHuang wrote:
> Hi,
>
> log message:
>
> [[[
>
> * subversion/tests/cmdline/commit_tests.py
> Add a test case for committing from multiple WC which have no common
> parent path. It is XFail now and will be changed to Pass after we have fix
> issue #2381.
> ]]]
Looks good, expect that you wrote the test to expect the commit
to fail, and then raise a failure exception.
Instead, we could make the test expect the commit to succeed.
For now, the test will fail when trying to commit and raise
an exception at that point.
Then, all we need to change later is to remove the XFail().
Do you agree?
Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2361490
Received on 2009-06-12 03:48:05 CEST