Re: [PATCH] commit_tests

On Thu, Jun 11, 2009 at 07:40:08PM +0800, HuiHuang wrote:
> Hi,
>
> log message:
>
> [[[
>
> * subversion/tests/cmdline/commit_tests.py
> Add a test case for committing from multiple WC which have no common
> parent path. It is XFail now and will be changed to Pass after we have fix
> issue #2381.
> ]]]

Looks good, expect that you wrote the test to expect the commit
to fail, and then raise a failure exception.

Instead, we could make the test expect the commit to succeed.
For now, the test will fail when trying to commit and raise
an exception at that point.

Then, all we need to change later is to remove the XFail().

Do you agree?

Stefan
Received on 2009-06-11 15:48:01 CEST