[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

naming in repos_diff.c

From: Neels Janosch Hofmeyr <neels_at_hofmeyr.de>
Date: Wed, 03 Jun 2009 22:03:50 +0200

Hi Arfrever, Stsp,

would you guys be fine with the attached patch? Calling that thing
"diff_editor" got me confused there for a while.

Furthermore, could you explain why you chuck the local svnpatch_* functions
into an (also local) svn_delta_editor_t in the first place? It makes much
more sense to me to just call them directly without the editor struct.

Thanks,
~Neels

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2359211

Received on 2009-06-04 04:11:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.