[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] make parse-diff.c compile with VC6

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Tue, 2 Jun 2009 23:03:57 -0700

On Fri, May 29, 2009 at 1:22 AM, Branko Čibej <brane_at_xbc.nu> wrote:
> Joe Swatosh wrote:
>> This is not part of the Ruby bindings so it is not for me to commit
>> without approval by a full committer. Is the patch acceptable with the
>> log message amended below?
>>  --
>> Joe
>>
>> [[[
>>
>> Make parse-diff.c compile with VC6 by including limits.h for ULONG_MAX.
>>
>> * subversion/libsvn_diff/parse-diff.c
>>   add include for limits.h to make sure ULONG_MAX defined
>>
>> ]]]
>>
>
>
> Well, to be pedantic, we usually include system headers before local
> ones, not after 'em; but, http://beige.bikeshed.com/ . Approved.
>
> -- Brane
>

r37915 (with the order changed).

Thanks,

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2358990
Received on 2009-06-03 08:04:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.