Re: svnsync tests may fail to FAIL?

On Sat, May 23, 2009 at 12:49:17AM +0200, Neels Janosch Hofmeyr wrote:
> Hi all,
>
> in svnsync_tests.py, I find these lines in the overall run_test() function:
>
> [[[
> run_sync(dest_sbox.repo_url)
> run_copy_revprops(dest_sbox.repo_url)
> ]]]
>
> As I was browsing the output of a test, I noticed that the properties were
> being synced *twice*. Once by svn_sync(), once by run_copy_revprops().
>
> In fact, if I remove the "run_copy_revprops()", all tests still pass fine.

I'd say copying the revprops again is redundant, unless the test
modifies revprops in the source repository before syncing again.

"svnsync copy-revprops" is only useful if revprops have changed for
a revision which has already been synced to the target. Recall that
revprops aren't versioned and can change at any time.

http://svnbook.red-bean.com/en/1.5/svn.ref.svnsync.c.copy-revprops.html

Stefan
Received on 2009-05-23 01:08:04 CEST