[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Make Ruby and Perl shared libraries .dll again

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 22 May 2009 14:52:36 +0100

On Thu, May 21, 2009 at 11:26:50PM -0700, Joe Swatosh wrote:
> Make the Ruby and Perl shared libraries .dll instead of .pyd. There is
> probably a smarter way to do this with the ._extension_map, but I'm no
> kind of Python expert.

Your log message and explanation of your patch do not contain any
reasoning about why r37331 needs to be reverted. Can you explain?
You seem to assume that everyone already knows what's wrong with
.pyd. But, for example, I don't even know what a .pyd is! :)

Please try to explain the reasoning behind a change in the log message.

Thanks,
Stefan

>
> [[[
>
> Partially revert r37331 "On Windows, shared libs for Python bindings
> should be *.pyd not *.dll." Change back to .dll for Ruby and Perl.
>
> * build/generator/gen_base.py (TargetSWIG.add_dependencies): Mark Python
> wrapper shared libs as type "pyd" not "lib".
>
> ]]]
>
> ===================================================================
> --- build/generator/gen_base.py (revision 37787)
> +++ build/generator/gen_base.py (working copy)
> @@ -550,12 +550,13 @@
> # Extract SWIG module name from .i file name
> module_name = iname[:4] != 'svn_' and iname[:-2] or iname[4:-2]
>
> - lib_extension = self.gen_obj._extension_map['pyd', 'target']
> + lib_extension = self.gen_obj._extension_map['lib', 'target']
> if self.lang == "ruby":
> lib_filename = module_name + lib_extension
> elif self.lang == "perl":
> lib_filename = '_' + module_name.capitalize() + lib_extension
> else:
> + lib_extension = self.gen_obj._extension_map['pyd', 'target']
> lib_filename = '_' + module_name + lib_extension
>
> self.name = self.lang + '_' + module_name
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2352771
Received on 2009-05-22 15:53:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.