Re: svn commit: r37709 - trunk/subversion/libsvn_subr

On Tue, May 12, 2009 at 20:20, Branko Cibej <brane_at_xbc.nu> wrote:
> Arfrever Frehtes Taifersar Arahesis wrote:
>>> Why is this necessary?
>>>
>>> If the error is useful, the full error message can be returned (as wrapped
>>> error?) in the svn_error_t* returned by this function
>>>
>>
>> The doc string of svn_dso_load() contains:
>> "If @a libname cannot be loaded set @a dso to NULL and return @c SVN_NO_ERROR."
>>
>> The error message might be useful to find bugs such as the one introduced
>> in r35309+r35385+r36823.
>>
>
> Never mind if it might be useful; we do not print anything from our
> libraries. It's just Not Done and I don't care about broken libraries
> that do expect to be able to print anything.

To be fair, the print is within SVN_DEBUG which means "only svn devs"

But yah: rev the API and improve the error return. Consumers can
always throw out the error.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2219332
Received on 2009-05-12 21:11:58 CEST