Re: svn commit: r37620 - in trunk/subversion/mod_dav_svn: . reports

On Wed, May 6, 2009 at 21:07, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Author: cmpilato
> Date: Wed May  6 12:07:20 2009
> New Revision: 37620
>
> Log:
> Introduce a non-varargs brigade printing function for mod_dav_svn to
> use, which reduces the overhead associated with unnecessary
> format-string parsing while still preserving the error-checking that
> the varargs form has.

Nice.

>...
> +++ trunk/subversion/mod_dav_svn/util.c Wed May  6 12:07:20 2009        (r37620)
> @@ -383,6 +383,23 @@ dav_svn__find_ns(apr_array_header_t *nam
>
>
>  svn_error_t *
> +dav_svn__brigade_print(apr_bucket_brigade *bb,
> +                       ap_filter_t *output,
> +                       const char *data)
> +{
> +  apr_status_t apr_err;
> +  apr_err = apr_brigade_write(bb, ap_filter_flush, output, data, strlen(data));

How about apr_brigade_puts() ?

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2092630
Received on 2009-05-07 11:48:56 CEST