[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37294 - in trunk/subversion: include libsvn_client libsvn_wc tests/cmdline tests/cmdline/svntest

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 16 Apr 2009 13:59:18 +0200

On Thu, Apr 16, 2009 at 13:53, Arfrever Frehtes Taifersar Arahesis
<Arfrever.FTA_at_gmail.com> wrote:
> 2009-04-16 13:33 Stefan Sperling <stsp_at_elego.de> napisaƂ(a):
>> On Thu, Apr 16, 2009 at 12:31:42PM +0100, Stefan Sperling wrote:
>>> On Thu, Apr 16, 2009 at 12:55:30PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
>>> > Public svn_wc_apply_svnpatch() function still exists. Would it make
>>> > sense to have a public function which applies unidiff parts of
>>> > patches?
>>>
>>> Quite possibly, yes. We can make a new one, or promote the
>>> apply_textdiffs() function in libsvn_client/patch.c to public.
>
> So the code which applies unidiff parts of patches is in libsvn_client,
> while the code which applies SVNPATCH1 blocks is in libsvn_wc?
> If yes, is this discrepancy intentional?

Certainly not. It is crappy code organization left over from the merge.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1746110
Received on 2009-04-16 13:59:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.