[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: merge.c question

From: Branko Cibej <brane_at_xbc.nu>
Date: Fri, 10 Apr 2009 05:23:23 +0200

Edmund Wong wrote:
> Hi,
>
> Can someone please clarify what this line means?
>
> #define ENSURE_VALID_REVISION_KINDS(rev1_kind, rev2_kind) \
>
>
> This is right before check_scheme_match() in
> subversion/libsvn_client/merge.c.
>

It's clearly a no-op, and cruft left over from some changes done in
merge.c in some unknown revision. I didn't go looking at all the diffs,
but the commit logs don't mention that change so *bonk* to whoever did
not follow commit log policy. BTW, I saw other problems in the commit
logs for that file; /me not happy. It looks like several times stuff was
committed with half-baked logs ...

Good catch, Edmund.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1622945
Received on 2009-04-10 05:23:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.