2009-04-09 11:35:38 Greg Stein napisał(a):
> On Thu, Apr 9, 2009 at 10:54, Arfrever Frehtes Taifersar Arahesis
> <arfrever.fta_at_gmail.com> wrote:
> > 2009-04-07 19:14:57 Greg Stein napisał(a):
> >> Everybody:
> >>
> >> The current trend of this thread is to follow the plan below.
IMHO this thread was about which Python versions are supported, not
about what to do with code related to currrently unsupported versions.
> >> Please speak up on your thoughts.
> >>
> >> I plan to take action to further this plan, beginning Thursday (that
> >> provides 72 hours for people to see this thread and provide their
> >> input).
> >>
> >> We are seeing some further failures in the test suite caused by the
> >> recent unicode changes. I want to give ample time for discussion, but
> >> also want to get moving on this to avoid problems like we're seeing in
> >> the tests.
> >
> > I can't reproduce any test failures, but in r37128 I reverted using of
> > unicode type in 'subversion/tests' directory.
>
> I wasted time tracking down a serf test failure a couple days ago,
> only to find it was because the output had been converted to Unicode,
> but the output verification pattern was non-Unicode. Thus, it couldn't
> find it.
I can't reproduce it:
>>> import re
>>> a = re.compile("abc")
>>> a.match("abcdef").group(0)
'abc'
>>> a.match(u"abcdef").group(0)
u'abc'
>>>
> r37128 brings in even more if/else branches for 3.0, so it is *still*
> adding complexity to a codebase which doesn't need it.
The minimal amount of additional complexity exists in very rarely changed
code and doesn't cause any problems. There are no technical reasons to
remove it.
> It is all coming out later today.
Please post patches for discussion before removing any code.
--
Arfrever Frehtes Taifersar Arahesis
Received on 2009-04-09 22:29:46 CEST